Open
Conversation
github-actions
bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #65953 by ensuring ANCMV2’s Windows installer dependency provider key differentiates arm64 installs from x64 installs, preventing incorrect reference counting across architectures.
Changes:
- Split the
ANCMDepProviderKeyMSBuild property into distinctx64andarm64values (instead of treating all non-x86 as x64).
src/Installers/Windows/AspNetCoreModule-Setup/ANCMV2/AncmV2.wixproj
Outdated
Show resolved
Hide resolved
joeloff
reviewed
Mar 25, 2026
Comment on lines
+24
to
+25
| <ANCMDepProviderKey Condition="'$(Platform)' == 'x64'">IISExpress_AspNetCore_Module_V2,x64</ANCMDepProviderKey> | ||
| <ANCMDepProviderKey Condition="'$(Platform)' == 'arm64'">IISExpress_AspNetCore_Module_V2,arm64</ANCMDepProviderKey> |
Member
There was a problem hiding this comment.
Might be simpler if we did <ANCMDepProviderKey>IISExpress_AspNetCore_Module_V2,$(Platform.ToLower())</ANCMDepProviderKey>
Member
|
@wtgodbe will you submit to tactics and look at porting to 8, 9, 10? |
Member
Author
Yes |
This was referenced Mar 28, 2026
Open
dotnet-policy-service
bot
added
the
pending-ci-rerun
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65953