fix flaky Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManagerTests.DeleteKeys#65989
Merged
DeagleGross merged 1 commit intoMar 27, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flakiness in XmlKeyManagerTests.DeleteKeys by removing reliance on DateTimeOffset.UtcNow for key creation/revocation timing, which could previously produce identical timestamps and break strict < comparisons used when cleaning up superseded mass-revocations.
Changes:
- Replaces
UtcNow-based key activation/revocation times with deterministic, fixed “epoch”-relative timestamps. - Ensures the two
RevokeAllKeyscalls use distinct, ordered timestamps so superseded mass revocations are reliably identifiable.
wtgodbe
approved these changes
Mar 26, 2026
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test calls
RevokeAllKeys(DateTimeOffset.UtcNow, ...)twice. Both calls can capture the same timestamp. WhenDeleteKeysruns, it tries to clean up superseded mass-revocations using strict <I ran the test locally and it failed multiple times before changes, but after it passed 50/50 times