Skip to content

[test-quarantine] Quarantine HttpsConfigurationTests#66032

Merged
wtgodbe merged 1 commit into
dotnet:mainfrom
wtgodbe:wtgodbe/quarantine-https-config
Mar 27, 2026
Merged

[test-quarantine] Quarantine HttpsConfigurationTests#66032
wtgodbe merged 1 commit into
dotnet:mainfrom
wtgodbe:wtgodbe/quarantine-https-config

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Mar 27, 2026

Associated issue: #66031

…g issue

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@wtgodbe wtgodbe requested a review from halter73 as a code owner March 27, 2026 15:23
Copilot AI review requested due to automatic review settings March 27, 2026 15:23
@wtgodbe wtgodbe requested a review from BrennanConroy as a code owner March 27, 2026 15:23
@github-actions github-actions Bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the quarantine tracking link for Kestrel HTTPS configuration tests that are being sequestered due to the OpenSSL MapOpenSsl30Code failure reported in #66031.

Changes:

  • Update the [QuarantinedTest] reason URL on HttpsConfigurationTests to point to issue #66031.

Comment on lines +18 to 19
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/66031")]
public class HttpsConfigurationTests
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying [QuarantinedTest] at the class level will quarantine all tests in this file, including NoFallbackToHttpAddress and LoadDefaultCertificate, which are not listed as failing in #66031. To avoid unnecessarily reducing coverage, consider moving the QuarantinedTest attribute onto only the failing test methods (BindAddressFromSetting/BindAddressFromEndpoint/UseHttpsJustWorks/UseHttpsMayNotImplyUseKestrelHttpsConfiguration/LoadEndpointCertificate) or splitting the flaky tests into a separate quarantined class.

Copilot uses AI. Check for mistakes.
@wtgodbe wtgodbe merged commit ba4fc27 into dotnet:main Mar 27, 2026
19 of 31 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview3 milestone Mar 27, 2026
@wtgodbe wtgodbe modified the milestones: 11.0-preview3, 11.0-preview4 Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants