Skip to content

Remove stale TBD diagnostic suppression from Directory.Build.props#66096

Merged
wtgodbe merged 1 commit intodotnet:mainfrom
wtgodbe:wtgodbe/remove-tbd-suppression
Apr 2, 2026
Merged

Remove stale TBD diagnostic suppression from Directory.Build.props#66096
wtgodbe merged 1 commit intodotnet:mainfrom
wtgodbe:wtgodbe/remove-tbd-suppression

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Apr 2, 2026

The TBD diagnostic code from dotnet/extensions#4130 was a placeholder that was never assigned an actual diagnostic ID. This suppression has no effect.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 2, 2026 02:02
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a no-op build warning suppression (TBD) from Directory.Build.props. This cleans up the repo-wide warning configuration by dropping an invalid diagnostic ID that was never assigned and therefore had no effect.

Changes:

  • Deleted the stale NoWarn entry for TBD from the warnings configuration block.

@wtgodbe wtgodbe merged commit c397851 into dotnet:main Apr 2, 2026
31 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview3 milestone Apr 2, 2026
@wtgodbe wtgodbe modified the milestones: 11.0-preview3, 11.0-preview4 Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants