Skip to content

Remove stale netstandard2.1 KnownFrameworkReference workaround#66099

Merged
wtgodbe merged 2 commits into
dotnet:mainfrom
wtgodbe:wtgodbe/remove-netstandard-workaround
Apr 2, 2026
Merged

Remove stale netstandard2.1 KnownFrameworkReference workaround#66099
wtgodbe merged 2 commits into
dotnet:mainfrom
wtgodbe:wtgodbe/remove-netstandard-workaround

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Apr 2, 2026

This workaround was added in 2019 for SDK PR dotnet/sdk#3463 which was merged for preview 8 of .NET Core 3.0. It has been unnecessary for over 6 years.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@wtgodbe wtgodbe requested a review from a team as a code owner April 2, 2026 02:03
Copilot AI review requested due to automatic review settings April 2, 2026 02:03
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an outdated MSBuild workaround in eng/Workarounds.targets that was originally added for a pre-.NET Core 3.0 SDK issue and is no longer needed in modern SDKs.

Changes:

  • Deleted the legacy KnownFrameworkReference update for NETStandard.Library that targeted a 2019 SDK preview-era issue.

@wtgodbe wtgodbe merged commit 24522a4 into dotnet:main Apr 2, 2026
25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/remove-netstandard-workaround branch April 2, 2026 14:13
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview3 milestone Apr 2, 2026
@wtgodbe wtgodbe modified the milestones: 11.0-preview3, 11.0-preview4 Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants