Remove stale EnableSingleFileAnalyzer workaround#66112
Merged
Merged
Conversation
The SDK now automatically enables EnableSingleFileAnalyzer when PublishAot=true or IsAotCompatible=true (dotnet/sdk#31284). This manual workaround is no longer needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-infrastructure
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an MSBuild workaround that manually mapped EnableAOTAnalyzer to EnableSingleFileAnalyzer, now that the .NET SDK enables EnableSingleFileAnalyzer automatically for AOT scenarios (PublishAot=true / IsAotCompatible=true).
Changes:
- Deleted the TODO and the conditional
EnableSingleFileAnalyzerproperty assignment inDirectory.Build.targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK now automatically enables
EnableSingleFileAnalyzerwhenPublishAot=trueorIsAotCompatible=true(see dotnet/sdk#31284). This manual workaround that copiedEnableAOTAnalyzertoEnableSingleFileAnalyzerhas been unnecessary since .NET 8.