[release/8.0] Move off of dead-lettered Windows preview helix queue#66220
Merged
Conversation
wtgodbe
requested review from
a team,
BrennanConroy,
JamesNK and
halter73
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Helix configuration and test skips to move IIS/HttpSys test runs off the dead-lettered Windows VS2022 preview Helix queue on the release/8.0 branch.
Changes:
- Replaces
Windows.Amd64.VS2022.Pre*queue names withWindows.Amd64.VS2022*in many[SkipOnHelix(...)]attributes across IIS and HttpSys tests. - Updates
Helix.Common.propsto advertiseWindows.Amd64.VS2022.Openinstead of the preview.Pre.Openqueue for PR checks.
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 42 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Servers/IIS/IISIntegration/test/Tests/IISMiddlewareTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IISIntegration/test/Tests/IISExtensionTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/UpgradeFeatureDetectionTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/OutOfProcess/NtlmAuthentationTest.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/OutOfProcess/MultipleAppTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/WebSocketTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/IISExpressShutdownTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/AppOfflineIISExpressTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.Tests/TlsHandshakeFeatureTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Tests/TestServerTest.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Tests/ResponseBodySizeTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Tests/ResponseAbortTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Tests/MaxRequestBodySizeTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Tests/HttpBodyControlFeatureTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.Tests/ConnectionIdFeatureTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/StdOutRedirectionTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.Shared.FunctionalTests/ApplicationInitializationTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.ShadowCopy.Tests/ShadowCopyTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/NewShimTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.NewHandler.FunctionalTests/NewHandlerTests.cs | Update SkipOnHelix queue name away from VS2022 preview queue |
| src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http3Tests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/IIS.FunctionalTests/Http2TrailersResetTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.LongTests/StartupTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.LongTests/ShutdownTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/WindowsAuthTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestPathBaseTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/MultiApplicationTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/MaxRequestBodySizeTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/LoggingTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/Latin1Tests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/HttpsTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/Http2Tests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/GlobalVersionTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/FrebTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/CompressionTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/BasicAuthTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/IIS/IIS/test/Common.FunctionalTests/AspNetCorePortTests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| src/Servers/HttpSys/test/FunctionalTests/Http2Tests.cs | Update SkipOnHelix queue names away from VS2022 preview queues |
| eng/targets/Helix.Common.props | Replace advertised Windows PR-check queue from VS2022 preview open queue to non-preview open queue |
|
|
||
| [Collection(PublishedSitesCollection.Name)] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre;Windows.Amd64.VS2022.Pre.Open;")] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022;Windows.Amd64.VS2022.Open;")] |
There was a problem hiding this comment.
Queues ends with a trailing ;. SkipOnHelixAttribute splits on ; and an empty entry matches every queue (targetQueue.StartsWith("")), so this ends up skipping on all Helix queues. Remove the trailing separator (and you can usually list just one queue name since the attribute already handles .Open vs non-.Open).
|
|
||
| [Collection(IISCompressionSiteCollection.Name)] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre;Windows.Amd64.VS2022.Pre.Open;")] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022;Windows.Amd64.VS2022.Open;")] |
There was a problem hiding this comment.
Queues ends with a trailing ;. SkipOnHelixAttribute splits on ; and an empty entry matches every queue (targetQueue.StartsWith("")), so this ends up skipping on all Helix queues. Remove the trailing separator (and you can usually list just one queue name since the attribute already handles .Open vs non-.Open).
Suggested change
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022;Windows.Amd64.VS2022.Open;")] | |
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022")] |
|
|
||
| [Collection(PublishedSitesCollection.Name)] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022.Pre;Windows.Amd64.VS2022.Pre.Open;")] | ||
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022;Windows.Amd64.VS2022.Open;")] |
There was a problem hiding this comment.
Queues ends with a trailing ;. SkipOnHelixAttribute splits on ; and an empty entry matches every queue (targetQueue.StartsWith("")), so this ends up skipping on all Helix queues. Remove the trailing separator (and you can usually list just one queue name since the attribute already handles .Open vs non-.Open).
Suggested change
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022;Windows.Amd64.VS2022.Open;")] | |
| [SkipOnHelix("Unsupported queue", Queues = "Windows.Amd64.VS2022")] |
github-actions
Bot
added
the
area-networking
This was referenced May 12, 2026
Open
Open
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview queue is dead