Enforce one PR per quarantine/unquarantine action#66296
Merged
Conversation
The agent was bundling multiple unrelated quarantine and unquarantine changes into a single PR. Add an explicit rule prohibiting this — separate PRs are easier to review, revert, and track. Observed in run 24338805833 where 2 quarantines + 1 unquarantine were combined into a single PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test-quarantine agent workflow prompt to explicitly prevent bundling multiple quarantine/unquarantine changes into a single PR, improving reviewability and allowing independent merge/revert of each action.
Changes:
- Add a new “Important Rules” bullet requiring a separate PR per quarantine and per unquarantine action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In workflow run 24338805833, the agent bundled 2 quarantines and 1 unquarantine into a single PR instead of creating 3 separate PRs. This makes review harder and prevents independent revert/merge of each action.
Changes
Added an explicit rule to the test-quarantine prompt prohibiting combining unrelated quarantine/unquarantine actions into a single PR.