Add [StringSyntax(Json)] to string parameters that accept JSON#66358
Open
KitKeen wants to merge 2 commits intodotnet:mainfrom
Open
Add [StringSyntax(Json)] to string parameters that accept JSON#66358KitKeen wants to merge 2 commits intodotnet:mainfrom
KitKeen wants to merge 2 commits intodotnet:mainfrom
Conversation
Adds StringSyntaxAttribute with Json identifier to parameters in SignInManager (credentialJson), DefaultWebAssemblyJSRuntime (argsJson, operationsJson), ComponentHub (argsJson), and CircuitHost (argsJson). Closes dotnet#44535
dotnet-policy-service
Bot
added
the
community-contribution
Author
|
@dotnet-policy-service agree |
Author
|
/azp run aspnetcore-ci |
|
Commenter does not have sufficient privileges for PR 66358 in repo dotnet/aspnetcore |
Youssef1313
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add [StringSyntax(Json)] to Blazor/Identity params accepting raw JSON.
Description
Annotates string parameters that accept JSON payloads with
[StringSyntax(StringSyntaxAttribute.Json)]so IDEs and analyzersprovide JSON syntax highlighting and validation. No runtime behavior change.
Affected APIs:
SignInManager.PerformPasskeyAttestationAsync(credentialJson)SignInManager.PerformPasskeyAssertionAsync(credentialJson)SignInManager.PasskeySignInAsync(credentialJson)DefaultWebAssemblyJSRuntime.EndInvokeJS(argsJson)DefaultWebAssemblyJSRuntime.BeginInvokeDotNet(argsJson)DefaultWebAssemblyJSRuntime.UpdateRootComponentsCore(operationsJson)ComponentHub.BeginInvokeDotNetFromJS(argsJson)CircuitHost.BeginInvokeDotNetFromJS(argsJson)Follows the existing pattern used in
NavigationManager,IInternalWebJSInProcessRuntime, andWebViewManagerin this repo,and mirrors JamesNK's previous PR #45146 that added the same
attribute to other call sites.
Fixes #44535