Combine ValidationSummary class attribute with custom classes#66364
Open
KitKeen wants to merge 2 commits intodotnet:mainfrom
Open
Combine ValidationSummary class attribute with custom classes#66364KitKeen wants to merge 2 commits intodotnet:mainfrom
KitKeen wants to merge 2 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Thanks for your PR, @KitKeen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
When a class attribute is supplied to <ValidationSummary /> via attribute splatting, append it to the built-in validation-errors class instead of replacing it. This matches the pattern used in InputBase, InputRadio, and QuickGrid via AttributeUtilities.CombineClassNames. Fixes dotnet#43860
KitKeen
force-pushed
the
fix/validation-summary-class-merge
branch
from
5feb043 to
cb9b513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine ValidationSummary class attribute with custom classes
Fixes #43860
Problem
Passing a
classattribute to<ValidationSummary />via attribute splatting silently overrode the built-invalidation-errorsclass:<ValidationSummary class="pt-2" data-test="x" />Before:
<ul class="pt-2" data-test="x">(validation-errors lost)After:
<ul class="pt-2 validation-errors" data-test="x">Fix
Use the existing
AttributeUtilities.CombineClassNames(...)helper thatInputBase,InputRadio, andQuickGridalready use. SplatAdditionalAttributesfirst, thenadd the merged
classattribute soProcessDuplicateAttributeskeeps the merged value.Tests
Added
ValidationSummaryTest.cscovering:<ul>when no messages