Skip to content

Run template tests pipeline on changes in Versions.props#66537

Merged
Youssef1313 merged 1 commit into
mainfrom
dev/ygerges/template-tests
Apr 30, 2026
Merged

Run template tests pipeline on changes in Versions.props#66537
Youssef1313 merged 1 commit into
mainfrom
dev/ygerges/template-tests

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

PR #66514 introduced a regression that wasn't caught because the pipeline was skipped. The Versions.props file carry versions that are used by the templates, and so changes there should trigger the tests.

Ideally, we might want to consider separating versions used only by templates to a separate file to avoid over-running the pipeline, but it's probably okay for now to do it this way, I think.

@wtgodbe

Copilot AI review requested due to automatic review settings April 30, 2026 08:55
@Youssef1313 Youssef1313 requested review from a team and wtgodbe as code owners April 30, 2026 08:55
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the template-tests PR pipeline is triggered when shared dependency versions change, preventing template regressions from being missed when only version files are updated.

Changes:

  • Add eng/Versions.props to the PR path filters for the template-tests pipeline.

Comment thread .azure/pipelines/template-tests-pr.yml
Comment thread .azure/pipelines/template-tests-pr.yml
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, LGTM

@Youssef1313 Youssef1313 merged commit 068c2d5 into main Apr 30, 2026
31 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/template-tests branch April 30, 2026 14:30
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview5 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants