Run template tests pipeline on changes in Versions.props#66537
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the template-tests PR pipeline is triggered when shared dependency versions change, preventing template regressions from being missed when only version files are updated.
Changes:
- Add
eng/Versions.propsto the PR path filters for the template-tests pipeline.
wtgodbe
requested changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #66514 introduced a regression that wasn't caught because the pipeline was skipped. The Versions.props file carry versions that are used by the templates, and so changes there should trigger the tests.
Ideally, we might want to consider separating versions used only by templates to a separate file to avoid over-running the pipeline, but it's probably okay for now to do it this way, I think.
@wtgodbe