Skip to content

Re-quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor#66539

Merged
wtgodbe merged 1 commit into
mainfrom
revert-66474-unquarantine/cache-tag-helper-57567-1aa787e99c9351e7
May 4, 2026
Merged

Re-quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor#66539
wtgodbe merged 1 commit into
mainfrom
revert-66474-unquarantine/cache-tag-helper-57567-1aa787e99c9351e7

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Apr 30, 2026

Reverts #66474

The test is still flaky. I re-opened #57567

Copilot AI review requested due to automatic review settings April 30, 2026 11:20
@Youssef1313 Youssef1313 requested a review from a team as a code owner April 30, 2026 11:20
@github-actions github-actions Bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the prior unquarantine of a flaky CacheTagHelper unit test by re-applying the repository’s quarantine mechanism, so CI can continue to sequester failures while the underlying issue is investigated/tracked.

Changes:

  • Mark CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor as quarantined again with a link to the tracking issue.

@Youssef1313
Copy link
Copy Markdown
Member Author

#66540 might or might not make this test stable.

@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Apr 30, 2026

@Youssef1313 do you have a link to a build where this test failed?

@wtgodbe wtgodbe changed the title Revert "[test-quarantine] Unquarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor" Re-quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor Apr 30, 2026
@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Apr 30, 2026

I updated the name of the PR so that the workflow won't try to unquar this test again

@wtgodbe wtgodbe changed the title Re-quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor Re-Quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor Apr 30, 2026
@wtgodbe wtgodbe changed the title Re-Quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor Re-quarantine CacheTagHelperTest.ProcessAsync_AwaitersUseTheResultOfExecutor Apr 30, 2026
@Youssef1313
Copy link
Copy Markdown
Member Author

Youssef1313 commented Apr 30, 2026

@wtgodbe wtgodbe enabled auto-merge (squash) April 30, 2026 16:40
@wtgodbe wtgodbe disabled auto-merge April 30, 2026 16:40
@wtgodbe wtgodbe enabled auto-merge (squash) April 30, 2026 16:40
@wtgodbe wtgodbe merged commit 9a8bcdb into main May 4, 2026
37 checks passed
@wtgodbe wtgodbe deleted the revert-66474-unquarantine/cache-tag-helper-57567-1aa787e99c9351e7 branch May 4, 2026 08:40
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview5 milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates re-quarantine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants