Skip to content

Update Composite ML-DSA OIDs to final IANA-assigned values#66576

Open
Copilot wants to merge 2 commits intomainfrom
copilot/update-composite-ml-dsa-oids
Open

Update Composite ML-DSA OIDs to final IANA-assigned values#66576
Copilot wants to merge 2 commits intomainfrom
copilot/update-composite-ml-dsa-oids

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

Update Composite ML-DSA OIDs to final IANA-assigned values

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

The Composite ML-DSA spec (draft-ietf-lamps-pq-composite-sigs-13) finalized its algorithm OIDs under the IANA arc. The .NET runtime was updated in dotnet/runtime#120077. This PR updates the 18 hardcoded Composite ML-DSA OID constants in CertificateConfigLoader.cs to match.

  • CertificateConfigLoader.cs: Replace all composite ML-DSA OID string constants from the old Entrust draft arc (2.16.840.1.114027.80.9.1.{0–17}) to the final IANA-assigned arc (1.3.6.1.5.5.7.6.{37–54}).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • datatracker.ietf.org
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)
  • https://api.github.com/repos/dotnet/runtime/pulls/120077
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)
  • www.rfc-editor.org
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 4, 2026 that may be closed by this pull request
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 4, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/1f00a4bd-7bc3-4241-bf20-a3e7968186c4

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>
Copilot AI changed the title [WIP] Update hardcoded composite ML-DSA OIDs in ASP.NET Core Update Composite ML-DSA OIDs to final IANA-assigned values May 4, 2026
Copilot AI requested a review from BrennanConroy May 4, 2026 19:28
@BrennanConroy BrennanConroy marked this pull request as ready for review May 4, 2026 19:48
@BrennanConroy BrennanConroy requested a review from halter73 as a code owner May 4, 2026 19:48
Copilot AI review requested due to automatic review settings May 4, 2026 19:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Kestrel’s certificate private-key loading logic to recognize Composite ML-DSA certificates using the finalized IANA-assigned algorithm OIDs, keeping Kestrel aligned with the updated .NET runtime OID set.

Changes:

  • Replaces 18 hardcoded Composite ML-DSA OID constants from the old Entrust draft arc to the final IANA-assigned arc (1.3.6.1.5.5.7.6.37.54).
  • Keeps the existing CompositeMLDsa import/copy path unchanged, only updating the identifiers it matches on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composite ML-DSA OIDs have been updated

3 participants