Update Composite ML-DSA OIDs to final IANA-assigned values#66576
Open
Update Composite ML-DSA OIDs to final IANA-assigned values#66576
Conversation
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Agent-Logs-Url: https://github.com/dotnet/aspnetcore/sessions/1f00a4bd-7bc3-4241-bf20-a3e7968186c4 Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update hardcoded composite ML-DSA OIDs in ASP.NET Core
Update Composite ML-DSA OIDs to final IANA-assigned values
May 4, 2026
BrennanConroy
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Kestrel’s certificate private-key loading logic to recognize Composite ML-DSA certificates using the finalized IANA-assigned algorithm OIDs, keeping Kestrel aligned with the updated .NET runtime OID set.
Changes:
- Replaces 18 hardcoded Composite ML-DSA OID constants from the old Entrust draft arc to the final IANA-assigned arc (
1.3.6.1.5.5.7.6.37–.54). - Keeps the existing CompositeMLDsa import/copy path unchanged, only updating the identifiers it matches on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Composite ML-DSA OIDs to final IANA-assigned values
Description
The Composite ML-DSA spec (draft-ietf-lamps-pq-composite-sigs-13) finalized its algorithm OIDs under the IANA arc. The .NET runtime was updated in dotnet/runtime#120077. This PR updates the 18 hardcoded Composite ML-DSA OID constants in
CertificateConfigLoader.csto match.CertificateConfigLoader.cs: Replace all composite ML-DSA OID string constants from the old Entrust draft arc (2.16.840.1.114027.80.9.1.{0–17}) to the final IANA-assigned arc (1.3.6.1.5.5.7.6.{37–54}).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
datatracker.ietf.org/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)https://api.github.com/repos/dotnet/runtime/pulls/120077/usr/bin/curl curl -s REDACTED(http block)www.rfc-editor.org/usr/bin/curl curl -s REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either: