Set IsPackable=true on Microsoft.AspNetCore.Components.Gateway so Pack produces the shipping nupkg#66579
Merged
danroth27 merged 1 commit intodotnet:mainfrom May 5, 2026
Conversation
Microsoft.NET.Sdk.Web.ProjectSystem.props sets <IsPackable>false</IsPackable> by default. The Gateway project uses the Web SDK with a custom <NuspecFile> and <IsShippingPackage>true</IsShippingPackage>, but Pack silently no-ops under the Web SDK default, so no shipping nupkg is produced. Set <IsPackable>true</IsPackable> explicitly so the existing nuspec is honored and Microsoft.AspNetCore.Components.Gateway.<version>.nupkg is produced into artifacts/packages/<config>/Shipping/ alongside the other shipping packages. Verified locally: before this change, ./eng/build.ps1 -pack -projects ... succeeds with 0 errors but produces no nupkg anywhere under artifacts/. After this change, the same invocation produces both the package and its symbols package in the Shipping folder, with the expected build/ targets and tools/ payload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
danroth27
pushed a commit
to dotnet/core
that referenced
this pull request
May 5, 2026
The Microsoft.AspNetCore.Components.Gateway package isn't being produced on the build feeds (the Web SDK defaults IsPackable to false, silently no-op'ing Pack). A fix is up at dotnet/aspnetcore#66579 but won't make Preview 4, so remove the section and TOC entry; we'll bring it back when the package ships. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes packaging for Microsoft.AspNetCore.Components.Gateway so the repo’s pack step actually emits the intended shipping NuGet package. It aligns the Gateway project with the existing custom-nuspec packaging setup already used for similar Components tooling.
Changes:
- Explicitly sets
IsPackable=trueonMicrosoft.AspNetCore.Components.Gateway. - Documents why the override is required when using
Microsoft.NET.Sdk.Web. - Ensures the existing custom
.nuspec-based pack flow can produce the shipping.nupkg.
wtgodbe
approved these changes
May 5, 2026
javiercn
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.AspNetCore.Components.Gatewayis configured as a shipping package (<IsShippingPackage>true</IsShippingPackage>) with a custom<NuspecFile>, but no nupkg has been produced on the dnceng feeds since the project was added in #65982. Root cause:Microsoft.NET.Sdk.Web.ProjectSystem.propsdefaultsIsPackabletofalse:Because Gateway uses
Sdk="Microsoft.NET.Sdk.Web"and never overridesIsPackable, the Pack target silently no-ops ΓÇö the<NuspecFile>and<IsShippingPackage>settings are ignored. (TheMicrosoft.AspNetCore.Components.WebAssembly.DevServerproject, which is the closest analog and ships correctly, uses plainMicrosoft.NET.Sdkand so doesn't hit this default.)Fix
Set
<IsPackable>true</IsPackable>explicitly inMicrosoft.AspNetCore.Components.Gateway.csproj. One-line change.Verification
Before:
After:
Inspecting the produced nupkg confirms the expected payload:
Microsoft.AspNetCore.Components.Gateway.nuspec<NuspecFile>build/Microsoft.AspNetCore.Components.Gateway.targetstools/blazor-gateway.{dll,exe}tools/Yarp.ReverseProxy.dll,tools/Microsoft.Extensions.ServiceDiscovery*.dll,tools/System.IO.Hashing.dlltools/blazor-gateway.runtimeconfig.json,tools/web.config,tools/blazor-gateway.deps.jsonTHIRD-PARTY-NOTICES.txt,Icon.pngWhy this matters for 11.0 P4
Without this fix,
dotnet add package Microsoft.AspNetCore.Components.Gateway --prereleasereturns no result on any feed, so the Gateway can only be exercised by building it locally and copying the host bits into a sample.cc @javiercn