Skip to content

Close quarantine issues via PR merge instead of manually#66605

Merged
wtgodbe merged 1 commit intodotnet:mainfrom
wtgodbe:wtgodbe/quarantine-issue-fix
May 6, 2026
Merged

Close quarantine issues via PR merge instead of manually#66605
wtgodbe merged 1 commit intodotnet:mainfrom
wtgodbe:wtgodbe/quarantine-issue-fix

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented May 6, 2026

The quarantine workflow was closing tracking issues immediately when creating unquarantine PRs — before the PR was even merged. If the PR was rejected or reverted, the issue would already be closed.

Instead, include Closes #issue in the unquarantine PR body so the issue is closed automatically by GitHub when the PR merges.

Changes:

  • Remove close-issue from safe-outputs config
  • Update Step 3.2 to use Closes in PR body instead of manual closure
  • Update budget docs (unquarantine no longer consumes issue closures)
  • Update atomicity rules

Instead of the workflow closing tracking issues directly when
creating unquarantine PRs, include 'Closes #issue' in the PR body
so the issue is closed automatically when the PR merges. This
ensures issues stay open until the unquarantine is actually merged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 6, 2026 17:12
@wtgodbe wtgodbe requested a review from a team as a code owner May 6, 2026 17:12
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 6, 2026
@wtgodbe wtgodbe merged commit cf5f3e2 into dotnet:main May 6, 2026
15 of 16 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview5 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants