Update Windows build images from 2019 to 2022#66761
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Azure Pipelines job definitions to use the newer 1ES Windows 2022 build images instead of the Windows 2019 images, aligning the repo’s CI/build infrastructure with updated hosted agent environments.
Changes:
- Updated the default Windows job pool configuration to use
1es-windows-2022/1es-windows-2022-open. - Updated Windows pool image references across CI stages/jobs in
.azure/pipelines/ci.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.azure/pipelines/jobs/default-build.yml |
Switches public/internal Windows pool image selection to Windows 2022 equivalents. |
.azure/pipelines/ci.yml |
Updates Windows image references for SDL source analysis and multiple Windows jobs to 1es-windows-2022. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
the
area-infrastructure
Contributor
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
force-pushed
the
wtgodbe/update-images-2.3
branch
from
2ceb0c4 to
fda52b2
Compare
Use demands list pattern for public pool (matching AspNetWebStack), and revert sourceAnalysisPool to 1es-windows-2022. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The windows.vs2019.amd64 images don't have Visual Studio installed, so KoreBuild can't find MSBuild. Add a step to download an xcopy-able MSBuild (RoslynTools.MSBuild 17.8.5) and put it on PATH before the build runs. Script borrowed from aspnet/AspNetWebStack (PR dotnet#442). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the xcopy MSBuild installation steps (KoreBuild doesn't use PATH to find MSBuild). Add a diagnostic step to default-build.yml that prints vswhere output so we can see what VS/Build Tools are available on the image and update korebuild.json requirements to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The windows.vs2019.amd64 image has Windows10SDK.19041 installed, not Windows10SDK.17134. Update korebuild.json to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The windows.vs2019.amd64 image has Windows10SDK.19041, not 17134. Update both ANCM V1 vcxprojs to target the available SDK. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all references to
1es-windows-2019(and1es-windows-2019-open) with1es-windows-2022(and1es-windows-2022-open) in.azure/pipelines/.