Skip to content

Revert Node 24.14.1 pin in default-build.yml#66979

Open
wtgodbe wants to merge 1 commit into
dotnet:mainfrom
wtgodbe:wtgodbe/unpin-node-2414
Open

Revert Node 24.14.1 pin in default-build.yml#66979
wtgodbe wants to merge 1 commit into
dotnet:mainfrom
wtgodbe:wtgodbe/unpin-node-2414

Conversation

@wtgodbe
Copy link
Copy Markdown
Member

@wtgodbe wtgodbe commented Jun 2, 2026 •
edited
Loading

What

Undoes the Node version pinning .yml changes from #66465, while keeping the two installNodeJs: false additions and the Cache@2 continueOnError: true.

Specifically reverts, in .azure/pipelines/jobs/default-build.yml (both job blocks):

  • Install Node 24.14.1 → Install Node 24.x
  • version: 24.14.1 → version: 24.x
  • Cache/restore keys node24.14.1 → node24

Not touched

Relates to #66465

Copilot AI review requested due to automatic review settings June 2, 2026 16:17
@wtgodbe wtgodbe requested a review from a team as a code owner June 2, 2026 16:17
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 2, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service Bot commented Jun 2, 2026

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe
Revert Node pin to 24.14.1 in default-build.yml
8ee1874 
Undoes the Node version pinning (24.x -> 24.14.1 and the node24 -> node24.14.1
cache key changes) introduced in dotnet#66465, while keeping the installNodeJs: false
additions and the Cache@2 continueOnError: true.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@wtgodbe wtgodbe force-pushed the wtgodbe/unpin-node-2414 branch from e4922c4 to 8ee1874 Compare June 2, 2026 16:19
Copilot AI reviewed Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Node.js patch-version pinning in the shared AzDO default-build.yml job template (back to 24.x), while preserving the existing approach of conditionally installing Node based on the installNodeJs parameter.

Changes:

  • Revert UseNode@1 from 24.14.1 back to 24.x in both job blocks.
  • Update node_modules cache keys from node24.14.1 back to node24 for broader reuse.
  • Remove continueOnError: true from the Cache@2 node_modules task.

@wtgodbe wtgodbe changed the title Revert Node 24.14.1 pin in default-build.yml (keep installNodeJs: false) Revert Node 24.14.1 pin in default-build.yml Jun 2, 2026
@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026

Seeing if nodejs/node#62991 has been resolved

Youssef1313
Youssef1313 approved these changes Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run multiple times before merge to ensure it was indeed fixed

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026

Let's run multiple times before merge to ensure it was indeed fixed

Yep, that's the plan

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026 •
edited
Loading

1st run all good
2nd run all good
3rd run all good
4th run all good
5th run all good
6th run all good
7th run all good
8th run all good

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 2, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 3, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 3, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 3, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe wtgodbe mentioned this pull request Jun 3, 2026
Merged
This was referenced Jun 3, 2026
Open
Open
@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 3, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Copy Markdown
Member Author

wtgodbe commented Jun 3, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Youssef1313 Youssef1313 Youssef1313 approved these changes

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wtgodbe @Youssef1313