Fix weak reference Kestrel test#67403
Merged
Merged
Conversation
See dotnet/runtime#129157 for some context.
BrennanConroy
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a quarantined Kestrel in-memory functional test to avoid accidentally rooting the HttpConnection on the test method’s async state machine, which could prevent it from being garbage collected and make the test unreliable.
Changes:
- Refactors connection creation/request send into a separate helper method to ensure the connection can be collected after disposal.
- Marks the helper method as non-inlinable and adds the required
System.Runtime.CompilerServicesimport.
Show a summary per file
| File | Description |
|---|---|
| src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs | Moves connection setup into a [MethodImpl(NoInlining)] helper to prevent GC rooting and stabilize the weak-reference-style test behavior. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Open
3 tasks
wtgodbe
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/runtime#129157 for some context.