Removed Content Type header for 304 response since no content is being returned#8557
Merged
pranavkm merged 3 commits intodotnet:masterfrom Mar 20, 2019
ChiragRupani:feature/8230removecontenttype304
Merged
Removed Content Type header for 304 response since no content is being returned#8557pranavkm merged 3 commits intodotnet:masterfrom ChiragRupani:feature/8230removecontenttype304
pranavkm merged 3 commits intodotnet:masterfrom
ChiragRupani:feature/8230removecontenttype304
Conversation
Eilon
added
the
area-mvc
pranavkm
reviewed
Mar 18, 2019
Contributor
|
@ChiragRupani could you make the changes I suggested here: #8557 (comment)? I'd also recommend rebasing on master. We had some build infrastructure issues that are addressed in more recent commits. |
…tent is being returned
pranavkm
reviewed
Mar 20, 2019
| if (preconditionState == PreconditionState.NotModified) | ||
| { | ||
| response.StatusCode = StatusCodes.Status304NotModified; | ||
| response.StatusCode = StatusCodes.Status304NotModified; |
Contributor
There was a problem hiding this comment.
Could you undo this change?
Contributor
Author
There was a problem hiding this comment.
Removed spaces
| { | ||
| // Assuming the request is not a range request, and the response body is not empty, the Content-Length header is set to | ||
| // the length of the entire file. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed spaces
Tratcher
approved these changes
Mar 20, 2019
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Addresses #8230