-
Notifications
You must be signed in to change notification settings - Fork 64
Add support for uninstalling .NET 10 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for uninstalling .NET 10 #405
Conversation
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
@copilot can you see the failed tests and fix them? I can give you a list if you can't see the results. |
I can't see the test results from the CI run. Could you please provide the list of failed tests so I can fix them? |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
@copilot you can run |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
... Fixed in commit 8ada181. The issue was that the .NET 10 range started at 10.0.100, which left versions like 10.0.1 outside any range. Changed it to start at 10.0.0 to cover all .NET 10 versions. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix these tests: |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Fixed in commit 01803de. Two issues:
|
|
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Fixed in commit 53a1bed:
|
|
@copilot fix the following tests:
|
@copilot a few test failures to fix:Microsoft.DotNet.Tools.Uninstall.Tests.Shared.VSVersioning.VSVersionTests.TestGetListCommandUninstallableStringsWindows(versions: ["2.1.500", "10.0.1", "10.0.0"], expectedStrings: [" 2017", "", "None"])
Microsoft.DotNet.Tools.Uninstall.Tests.Shared.VSVersioning.VSVersionTests.TestGetUninstallableNonSdkVersionsWindows(versions: ["5.0.100", "5.0.101", "10.0.1"], allowed: [True, False, False]) |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Fixed in commit 81f1158:
|
@copilot one more test to fixMicrosoft.DotNet.Tools.Uninstall.Tests.Shared.VSVersioning.VSVersionTests.TestGetListCommandUninstallableStringsWindows(versions: ["2.1.500", "10.0.1", "10.0.0"], expectedStrings: [" 2017", "", "None"]) |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Fixed in commit f02d3ca. Changed the VS version for the [10.0.0, 10.0.100) range from " 2026" to "" (empty string) to match the pattern used for runtime/early versions and align with the test expectation. |
Removed an entry for SemanticVersion 10.0.0 to 10.0.100.
|
@copilot two more failing tests to fix.
Do not edit VisualStudioSafeVersionsExtractor.cs anymore as it's correct. |
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
|
@copilot please try again: #405 (comment) |
Fixed in commit 4a7c850. Updated test expectations for versions 10.0.0 and 10.0.1:
These versions fall outside the [10.0.100, 11.0.0) range and are treated as uninstallable. |
…copilot missed (and some that were wrong in the 9 PR).
|
All tests passed locally. I confirmed list showed the 10.0.100 SDK and was able to remove it with my local build on windows. Need vendor pass next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this - the changes look good, and I'm happy to see how small it is in comparison to prior years. Approving to ship once vendor tests are complete and look good.
|
When will this be included in a release? I'd like to uninstall the .NET 10 preview ;) |
|
@danihengeveld Already answered in #403 |



Fixes #403
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.