Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit 68b7810

Browse files
committed
Adding NU5123 to the NOWARN list. This was a new warning introduced by NuGet that we started hitting when upgrading to a newer SDK.
1 parent c5a7745 commit 68b7810

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

build/BuildDefaults.props

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
<!-- Since we disabled the implict fallback to net461, this will only kick in when we have an explicit fallback and we don't need to be warned about it doing what we asked it to do. -->
3131
<!-- NU5104: Disable 'A stable release of a package should not have a prerelease dependency' warning globally -->
3232
<!-- The "pack" command under 'buildCrossTargeting' for 'Microsoft.DotNet.MSBuildSdkResolver' throws a "NU5104" warning/error while using a "2.1.300" stage0 SDK. For: Linux-x64, Linux-arm, and Linux-arm64 -->
33-
<NoWarn>NU1701;NU5104</NoWarn>
33+
<!-- NU5123: Disable warning for package installation path is too long. We are hitting this for some ni...map file in one of our packages. -->
34+
<NoWarn>NU1701;NU5104;NU5123</NoWarn>
3435

3536
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3637
<MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>

run-build.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ if($Architecture.StartsWith("arm", [StringComparison]::OrdinalIgnoreCase))
9292
$InstallArchitecture = "x64"
9393
}
9494

95-
Write-Output "$dotnetInstallPath -version ""2.1.300"" -InstallDir $env:DOTNET_INSTALL_DIR -Architecture ""$InstallArchitecture"""
96-
Invoke-Expression "$dotnetInstallPath -version ""2.1.300"" -InstallDir $env:DOTNET_INSTALL_DIR -Architecture ""$InstallArchitecture"""
95+
Write-Output "$dotnetInstallPath -version ""2.1.403"" -InstallDir $env:DOTNET_INSTALL_DIR -Architecture ""$InstallArchitecture"""
96+
Invoke-Expression "$dotnetInstallPath -version ""2.1.403"" -InstallDir $env:DOTNET_INSTALL_DIR -Architecture ""$InstallArchitecture"""
9797

9898
if ($LastExitCode -ne 0)
9999
{

run-build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ if [[ $archlower == 'arm'* ]]; then
165165
fi
166166

167167
if [ "$STAGE0_SOURCE_DIR" == "" ]; then
168-
(set -x ; "$REPOROOT/scripts/obtain/dotnet-install.sh" --version "2.1.300" --install-dir "$DOTNET_INSTALL_DIR" --architecture "$INSTALL_ARCHITECTURE" $LINUX_PORTABLE_INSTALL_ARGS)
168+
(set -x ; "$REPOROOT/scripts/obtain/dotnet-install.sh" --version "2.1.403" --install-dir "$DOTNET_INSTALL_DIR" --architecture "$INSTALL_ARCHITECTURE" $LINUX_PORTABLE_INSTALL_ARGS)
169169
else
170170
echo "Copying bootstrap cli from $STAGE0_SOURCE_DIR"
171171
cp -r $STAGE0_SOURCE_DIR/* "$DOTNET_INSTALL_DIR"

0 commit comments

Comments
 (0)