Api Diff between preview 7 and preview 6#4977
Api Diff between preview 7 and preview 6#4977Anipik merged 1 commit intodotnet:masterfrom Anipik:preview7
Conversation
|
Signed off on |
|
adding @MichalStrehovsky for DynamicallyAccessedMemberTypes enum rename |
| # Microsoft.AspNetCore.Authentication | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Authentication { |
|
DynamicallyAccessedMemberTypes enum rename looks good. |
|
FYI @Anipik I'm no longer with the .NET team, so should be removed from the list of reviewers for API diffs. The others you currently have on the list should already be providing coverage for my areas (or reach out to @Pilchie for other area owners in ASP.NET). Looks like y'all have done a lot of cool work though! 🎉 |
|
can everyone tagged please review their areas ? |
|
System.Text and System.Threading.Tasks looks good to me. |
| ``` diff | ||
| namespace System.Net { | ||
| public class WebHeaderCollection : NameValueCollection, IEnumerable, ISerializable { | ||
| - public new string this[string name] { get; set; } |
There was a problem hiding this comment.
This was removed from ref in PR dotnet/runtime#37949 ... we still inherit it from NameValueCollection
Approved on behalf of @dotnet/ncl
echesakov
left a comment
echesakov
left a comment
There was a problem hiding this comment.
Signed off on System.Runtime.Intrinsics and System.Runtime.Intrinsics.Arm
parts of AspNetCore.| # Microsoft.AspNetCore.Server.Kestrel.Core | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Server.Kestrel.Core { |
| ``` diff | ||
| namespace Microsoft.Net.Http.Headers { | ||
| public class SetCookieHeaderValue { | ||
| + public IList<StringSegment> Extensions { get; } |
tannergooding
left a comment
tannergooding
left a comment
There was a problem hiding this comment.
Also signed off on Intrinsics.
Signed off on the numerics changes (System.Math and System.Half) as well. CC. @pgovind
bartonjs
left a comment
bartonjs
left a comment
There was a problem hiding this comment.
System.Security.* and System.Formats.Asn1 LGTM.
Surprised that System.Formats.Cbor isn't in the list.
13 participants
cc @carlossanlop @jozkee @dotnet/ncl @steveharter @AaronRobinsonMSFT @jkoritzinsky @tannergooding @CarolEidt @echesakovMSFT @layomia @krwq @tarekgh @bartonjs @stephentoub @tommcdon @krwq @ericstj @richlander
@mkArtakMSFT @pranavkm @halter73 @Tratcher @BrennanConroy @anurse