This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
This change enables build with clang 4.0 and fixes a bunch of new errors that the stricter compiler was reporting.
Member
Author
|
Fixes #11159 |
jkotas
approved these changes
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables build with clang 4.0 and fixes a bunch of new errors that
the stricter compiler was reporting.
The new clang has
_rotland_rotras intrinsics, complains about > 0 comparison of pointers, reports as error invalid constant literal-9223372036854775808LL(the literal type suffix applies to the value without the sign and so it overflows the long long type) and also had issues with _umul128 parameter types.Since UnsignedMultiply128 that is defined as _umul128 and none of its callers are used anywhere, I have just deleted it and all of its callers.