Remove Span(T[], int) ctor#13575
Conversation
3f93525 to
c1c8a41
Compare
|
You should get the corefx PR through first. This one should be second. |
|
Actually, it would be best to split this PR into 2 PRs, and use this order to get them in:
This would minimize the disruption from tests failing temporarily. |
* Remove Span(T[], int) ctor - from issue #23471 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
* Remove Span(T[], int) ctor - from issue #23471 Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
@ahsonkhan @jkotas @stephentoub since this PR merged, all of our xunit wrappers have been failing with:
This is causing mission control tests to be on the floor: https://mc.dot.net/#/product/netcore/master/source/official~2Fcoreclr~2Fmaster~2F/type/test~2Ffunctional~2Fcli~2F/build/20170825.03 Can one of you take a look at this, or revert this PR while I try to figure out where we're using that instance of this method? |
|
We need to get #13510 through to fix this. |
|
This should be fixed now. |
Step 1 to resolve issue https://github.com/dotnet/corefx/issues/23471Edit: Step 2 to resolve issue https://github.com/dotnet/corefx/issues/23471
cc @shiftylogic, @stephentoub, @jkotas