Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove Span(T[], int) ctor#13575

Merged
jkotas merged 4 commits intodotnet:masterfrom
ahsonkhan:RemoveSpanCtor
Aug 25, 2017
Merged

Remove Span(T[], int) ctor#13575
jkotas merged 4 commits intodotnet:masterfrom
ahsonkhan:RemoveSpanCtor

Conversation

@ahsonkhan
Copy link
Copy Markdown

@ahsonkhan ahsonkhan commented Aug 24, 2017

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Aug 24, 2017

You should get the corefx PR through first. This one should be second.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Aug 24, 2017

Actually, it would be best to split this PR into 2 PRs, and use this order to get them in:

  1. Test update in CoreCLR
  2. CoreFX change
  3. CoreLib update in CoreCLR

This would minimize the disruption from tests failing temporarily.

@jkotas jkotas merged commit 5371352 into dotnet:master Aug 25, 2017
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Aug 25, 2017
* Remove Span(T[], int) ctor - from issue #23471

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@ahsonkhan ahsonkhan deleted the RemoveSpanCtor branch August 25, 2017 18:14
jkotas pushed a commit to dotnet/corert that referenced this pull request Aug 25, 2017
* Remove Span(T[], int) ctor - from issue #23471

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
@wtgodbe
Copy link
Copy Markdown
Member

wtgodbe commented Aug 28, 2017

@ahsonkhan @jkotas @stephentoub since this PR merged, all of our xunit wrappers have been failing with:

Unhandled Exception: System.MissingMethodException: Method not found: 'Void System.Span`1..ctor(!0[], Int32)'.

This is causing mission control tests to be on the floor: https://mc.dot.net/#/product/netcore/master/source/official~2Fcoreclr~2Fmaster~2F/type/test~2Ffunctional~2Fcli~2F/build/20170825.03

Can one of you take a look at this, or revert this PR while I try to figure out where we're using that instance of this method?

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Aug 28, 2017

We need to get #13510 through to fix this.

@karelz karelz modified the milestone: 2.1.0 Aug 28, 2017
@jkotas
Copy link
Copy Markdown
Member

jkotas commented Aug 28, 2017

This should be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants