This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[Arm64/Linux] Fix GenericPInvokeCalliHelper #17705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This is pretty corner case functionality. I do not think that it is something that will be accepted for release 2.1 branch. |
Author
|
Closing based on @jkotas assertion |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RussKeldorph @adityamandaleeka @jkotas This is an ask to port #17659 to release/2.1
This fixes one corefx test, the CALLI implementation for arm64 and removes some redundant amd64 operations. I can make it ARM64 specific, if anyone has concerns about the amd64 changes.