This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Expose Module.ModuleVersionId#1781
Merged
Merged
Conversation
Member
|
LGTM |
Member
|
LGTM - Remember once this mirrors internal it is going to break the build because of the asmmeta update. |
Author
|
@weshaggard Thanks for the reminder. I'm readying the change on the internal side. |
nguerrera
added a commit
that referenced
this pull request
Oct 16, 2015
Expose Module.ModuleVersionId
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Expose Module.ModuleVersionId Commit migrated from dotnet/coreclr@e83ca43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in support of dotnet/corefx#2375
The POR is not to expose it directly on Module in the core reflection contract but via a TryGet extension that is allowed to simply return false on platforms without this capability. The CoreCLR implementation of that extension will call Module.ModuleVersionId in mscorlib.
cc @jkotas @weshaggard