Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Replace gtNextStmt with GetNextStmt() #26801

Merged
merged 2 commits into from
Sep 20, 2019
Merged

Replace gtNextStmt with GetNextStmt() #26801

merged 2 commits into from
Sep 20, 2019

Conversation

@franksinankaya
Copy link

@franksinankaya franksinankaya commented Sep 20, 2019

@am11 @jkotas @janvorli @dotnet/jit-contrib

@franksinankaya franksinankaya changed the title find ./ -type f -exec sed -i -e 's/\<gtNextStmt\>/getNextStmt()/g' {} \; find ./ -type f -exec sed -i -e 's/\<gtNextStmt\>/GetNextStmt()/g' {} \; Sep 20, 2019
@franksinankaya
Copy link
Author

franksinankaya commented Sep 20, 2019

cc @dotnet/jit-contrib

@am11
Copy link
Member

am11 commented Sep 20, 2019

probably it is also one step towards removing -Wno-*microsoft*, -Wno-*ms*, -fms-extensions etc. from cmake configs. :)

@mikedn
Copy link

mikedn commented Sep 20, 2019

cc @sandreenko Since he's working on statements :)

sandreenko
sandreenko approved these changes Sep 20, 2019
View reviewed changes
Copy link

@sandreenko sandreenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@franksinankaya
Copy link
Author

franksinankaya commented Sep 20, 2019

Please help review and merge these small changes.

@sandreenko sandreenko merged commit 9d999c5 into dotnet:master Sep 20, 2019
@BruceForstall BruceForstall changed the title find ./ -type f -exec sed -i -e 's/\<gtNextStmt\>/GetNextStmt()/g' {} \; Replace gtNextStmt with GetNextStmt() Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sandreenko sandreenko sandreenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@franksinankaya @am11 @mikedn @sandreenko