This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix run-test.sh#16170
Merged
danmoseley merged 2 commits intodotnet:masterfrom Feb 15, 2017
hseok-oh:fix_runtest
Merged
Conversation
This makes run-test.sh work in x64/linux. Remove useless argument and add --runtime argument to pass runtime directory Not works in cross compile yet (ex. build in x64 & run in arm)
Author
|
The best solution is to use build-test.sh instead of separate script for test, but we need run-test.sh for arm build yet. To use in arm build, we need to modify Microsoft.NETCore.App.dep.json in bin/testhost manually. |
remove chmod and check RunTests.sh existing
Member
|
@dotnet-bot test this please (Jenkins was down) |
Member
|
@hseok-oh we have issue https://github.com/dotnet/corefx/issues/15814 tracking to fix run-tests scripts to try and add a "run" mode to build-tests to help eliminate this duplication of work. cc @danmosemsft |
Member
|
Looks good, thanks. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix run-test.sh This makes run-test.sh work in x64/linux. Remove useless argument and add --runtime argument to pass runtime directory Not works in cross compile yet (ex. build in x64 & run in arm) * Fix run-test.sh remove chmod and check RunTests.sh existing Commit migrated from dotnet/corefx@b55af9c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes run-test.sh work in x64/linux.
Remove useless argument and add --runtime argument to pass runtime directory
Not works for cross compile yet (ex. build in x64 & run in arm)