Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[ARM/CI] Enable manual CI triggering for arm and armel#16378

Merged
weshaggard merged 1 commit intodotnet:masterfrom
hqueue:arm/ci_enable
Feb 24, 2017
Merged

[ARM/CI] Enable manual CI triggering for arm and armel#16378
weshaggard merged 1 commit intodotnet:masterfrom
hqueue:arm/ci_enable

Conversation

@hqueue
Copy link
Copy Markdown
Member

@hqueue hqueue commented Feb 22, 2017 •
edited
Loading

  1. Enable following manual CI triggering for arm and armel.

    innerloop Ubuntu arm Release Cross Build
    innerloop Ubuntu arm Debug Cross Build
    innerloop Ubuntu16.04 arm Release Cross Build
    innerloop Ubuntu16.04 arm Debug Cross Build
    innerloop Tizen armel Release Cross Build
    innerloop Tizen armel Debug Cross Build

    Which replaces following old style commands.
    innerloop linuxarmemulator HardFP Release
    innerloop linuxarmemulator HardFP Debug
    innerloop linuxarmemulator SoftFP Release
    innerloop linuxarmemulator SoftFP Debug

  2. Prepare bin/build.tar.gz correctly to run unit tests in coreclr CI for arm and armel. Before netci.groovy made old-fashioned build.tar.gz.

  3. Add some options to arm32 CI script.

  4. Rename scripts/arm32_ci_script.sh to cross/arm32_ci_script.sh

Related issues: https://github.com/dotnet/core-setup/issues/790

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot help

@dotnet-bot
Copy link
Copy Markdown

dotnet-bot commented Feb 22, 2017

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand
Comment Phrase Action
@dotnet-bot test this please Re-run all legs. Use sparingly
@dotnet-bot test ci please Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:master.

Click to expand
Comment Phrase Job Launched
@dotnet-bot test Windows_NT Debug AllConfigurations Build Windows_NT Debug AllConfigurations Build
@dotnet-bot test Innerloop CentOS7.1 Debug Build and Test Innerloop CentOS7.1 Debug Build and Test
@dotnet-bot test Innerloop CentOS7.1 Release Build and Test Innerloop CentOS7.1 Release Build and Test
@dotnet-bot test Innerloop OSX Debug Build and Test Innerloop OSX Debug Build and Test
@dotnet-bot test Innerloop OSX Release Build and Test Innerloop OSX Release Build and Test
@dotnet-bot test Innerloop PortableLinux Debug Build and Test Innerloop PortableLinux Debug Build and Test
@dotnet-bot test Innerloop PortableLinux Release Build and Test Innerloop PortableLinux Release Build and Test
@dotnet-bot test Vertical uap Build Vertical uap Build
@dotnet-bot test Vertical uapaot Build Vertical uapaot Build
@dotnet-bot test Innerloop Ubuntu14.04 Debug Build and Test Innerloop Ubuntu14.04 Debug Build and Test
@dotnet-bot test Innerloop Ubuntu14.04 Release Build and Test Innerloop Ubuntu14.04 Release Build and Test
@dotnet-bot test Innerloop Windows_NT Debug Build and Test Innerloop Windows_NT Debug Build and Test
@dotnet-bot test Innerloop Windows_NT Release Build and Test Innerloop Windows_NT Release Build and Test

The following optional jobs are available in PRs against dotnet/corefx:master.

Click to expand
Comment Phrase Job Launched
@dotnet-bot test code coverage Queues Code Coverage Windows Debug
@dotnet-bot test innerloop Debian8.4 Debug Queues Innerloop Debian8.4 Debug Build and Test
@dotnet-bot test innerloop Debian8.4 Release Queues Innerloop Debian8.4 Release Build and Test
@dotnet-bot test innerloop Fedora23 Debug Queues Innerloop Fedora23 Debug Build and Test
@dotnet-bot test innerloop Fedora23 Release Queues Innerloop Fedora23 Release Build and Test
@dotnet-bot test innerloop Fedora24 Debug Queues Innerloop Fedora24 Debug Build and Test
@dotnet-bot test innerloop Fedora24 Release Queues Innerloop Fedora24 Release Build and Test
@dotnet-bot test innerloop linuxarmemulator HardFP Debug Queues Innerloop Linux ARM Emulator HardFP Debug Cross Build
@dotnet-bot test innerloop linuxarmemulator HardFP Release Queues Innerloop Linux ARM Emulator HardFP Release Cross Build
@dotnet-bot test innerloop linuxarmemulator SoftFP Debug Queues Innerloop Linux ARM Emulator SoftFP Debug Cross Build
@dotnet-bot test innerloop linuxarmemulator SoftFP Release Queues Innerloop Linux ARM Emulator SoftFP Release Cross Build
@dotnet-bot test code formatter check Queues Code Formatter Check
@dotnet-bot test innerloop OpenSUSE13.2 Debug Queues Innerloop OpenSUSE13.2 Debug Build and Test
@dotnet-bot test innerloop OpenSUSE13.2 Release Queues Innerloop OpenSUSE13.2 Release Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Debug Queues Innerloop OpenSUSE42.1 Debug Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Release Queues Innerloop OpenSUSE42.1 Release Build and Test
@dotnet-bot test outerloop CentOS7.1 Debug Queues OuterLoop CentOS7.1 Debug
@dotnet-bot test outerloop CentOS7.1 Release Queues OuterLoop CentOS7.1 Release
@dotnet-bot test outerloop Debian8.4 Debug Queues OuterLoop Debian8.4 Debug
@dotnet-bot test outerloop Debian8.4 Release Queues OuterLoop Debian8.4 Release
@dotnet-bot test outerloop Fedora23 Debug Queues OuterLoop Fedora23 Debug
@dotnet-bot test outerloop Fedora23 Release Queues OuterLoop Fedora23 Release
@dotnet-bot test outerloop Fedora24 Debug Queues OuterLoop Fedora24 Debug
@dotnet-bot test outerloop Fedora24 Release Queues OuterLoop Fedora24 Release
@dotnet-bot test outerloop OpenSUSE13.2 Debug Queues OuterLoop OpenSUSE13.2 Debug
@dotnet-bot test outerloop OpenSUSE13.2 Release Queues OuterLoop OpenSUSE13.2 Release
@dotnet-bot test outerloop OpenSUSE42.1 Debug Queues OuterLoop OpenSUSE42.1 Debug
@dotnet-bot test outerloop OpenSUSE42.1 Release Queues OuterLoop OpenSUSE42.1 Release
@dotnet-bot test outerloop OSX Debug Queues OuterLoop OSX Debug
@dotnet-bot test outerloop OSX Release Queues OuterLoop OSX Release
@dotnet-bot test outerloop PortableLinux Debug Queues OuterLoop PortableLinux Debug
@dotnet-bot test outerloop PortableLinux Release Queues OuterLoop PortableLinux Release
@dotnet-bot test outerloop RHEL7.2 Debug Queues OuterLoop RHEL7.2 Debug
@dotnet-bot test outerloop RHEL7.2 Release Queues OuterLoop RHEL7.2 Release
@dotnet-bot test outerloop Ubuntu14.04 Debug Queues OuterLoop Ubuntu14.04 Debug
@dotnet-bot test outerloop Ubuntu14.04 Release Queues OuterLoop Ubuntu14.04 Release
@dotnet-bot test outerloop Ubuntu16.04 Debug Queues OuterLoop Ubuntu16.04 Debug
@dotnet-bot test outerloop Ubuntu16.04 Release Queues OuterLoop Ubuntu16.04 Release
@dotnet-bot test outerloop Ubuntu16.10 Debug Queues OuterLoop Ubuntu16.10 Debug
@dotnet-bot test outerloop Ubuntu16.10 Release Queues OuterLoop Ubuntu16.10 Release
@dotnet-bot test outerloop Windows 10 Debug Queues OuterLoop Windows 10 Debug
@dotnet-bot test outerloop Windows 10 Release Queues OuterLoop Windows 10 Release
@dotnet-bot test outerloop Windows 7 Debug Queues OuterLoop Windows 7 Debug
@dotnet-bot test outerloop Windows 7 Release Queues OuterLoop Windows 7 Release
@dotnet-bot test outerloop Windows_NT Debug Queues OuterLoop Windows_NT Debug
@dotnet-bot test outerloop Windows_NT Release Queues OuterLoop Windows_NT Release
@dotnet-bot test outerloop Windows Nano 2016 Debug Queues OuterLoop Windows Nano 2016 Debug
@dotnet-bot test outerloop Windows Nano 2016 Release Queues OuterLoop Windows Nano 2016 Release
@dotnet-bot test innerloop RHEL7.2 Debug Queues Innerloop RHEL7.2 Debug Build and Test
@dotnet-bot test innerloop RHEL7.2 Release Queues Innerloop RHEL7.2 Release Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Debug Queues Innerloop Ubuntu16.04 Debug Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Release Queues Innerloop Ubuntu16.04 Release Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Debug Queues Innerloop Ubuntu16.10 Debug Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Release Queues Innerloop Ubuntu16.10 Release Build and Test

Have a nice day!

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue hqueue force-pushed the arm/ci_enable branch 2 times, most recently from 3a96574 to b7d557e Compare February 22, 2017 11:17
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue hqueue changed the title [ARM/CI][WIP] Enable CI for arm and armel [ARM/CI] Enable manual CI triggering for arm and armel Feb 22, 2017
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@gkhanna79 @mellinoe PTAL.
I've update netci.groovy and CI script. It is also required to enable unit tests in coreclr CI for arm and armel.

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 22, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Debug
@dotnet-bot test innerloop linuxarmemulator SoftFP Debug

@mellinoe
Copy link
Copy Markdown
Contributor

mellinoe commented Feb 22, 2017

This looks good to me. @gkhanna79 do you want to take a quick look?

@hqueue hqueue mentioned this pull request Feb 23, 2017
Merged
weshaggard
weshaggard reviewed Feb 24, 2017
View reviewed changes
scripts/arm32_ci_script.sh
@@ -9,23 +9,23 @@ function usage {
echo ' corefx source is at ~/cfx'
Copy link
Copy Markdown
Member

@weshaggard weshaggard Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please move this script under the cross folder like the other similar scripts?

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename it.

@hqueue
Enable manual CI triggering for arm and armel
5e6507e 
1. Enable following manual CI triggering for arm and armel.
  Innerloop Ubuntu arm Release Cross Build
  Innerloop Ubuntu arm Debug Cross Build
  Innerloop Ubuntu16.04 arm Release Cross Build
  Innerloop Ubuntu16.04 arm Debug Cross Build
  Innerloop Tizen armel Release Cross Build
  Innerloop Tizen armel Debug Cross Build

  Which replaces following old style commands.
    innerloop linuxarmemulator HardFP Release
    innerloop linuxarmemulator HardFP Debug
    innerloop linuxarmemulator SoftFP Release
    innerloop linuxarmemulator SoftFP Debug

2. Prepare bin/build.tar.gz correctly to run unit tests in coreclr CI for arm and armel.
   Before netci.groovy made old-fashioned build.tar.gz.

3. Add some options to arm32 CI script.

4. Rename scripts/arm32_ci_script.sh to cross/arm32_ci_script.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 24, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator HardFP Release
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Debug
@dotnet-bot test innerloop linuxarmemulator SoftFP Debug

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 24, 2017 •
edited
Loading

@weshaggard I've renamed the script scripts/arm32_ci_script.sh to cross/arm32_ci_script.sh. Is it ok?

@mellinoe @gkhanna79 @weshaggard PTAL
After @mellinoe approved, I've renamed the script following @weshaggard feedback.
As a result, four arm32 related CI are failed as exepected because the script is not found. It is expected failure since changes (renaming the script) in netci.groovy is not applied yet. I think it will work without problem after merging this PR, at least it work well before renaming the script when @mellinoe approved.
Therefore please merge this PR :)

If there is more change required, I think we can apply it after merging this PR.

@weshaggard
Copy link
Copy Markdown
Member

weshaggard commented Feb 24, 2017

@weshaggard I've renamed the script scripts/arm32_ci_script.sh to cross/arm32_ci_script.sh. Is it ok?

Yes that is fine with me.

weshaggard
weshaggard reviewed Feb 24, 2017
View reviewed changes
cross/arm32_ci_script.sh
@@ -9,23 +9,23 @@ function usage {
echo ' corefx source is at ~/cfx'
echo '$ cd ~/cfx'
echo '$ ./scripts/arm32_ci_script.sh'
Copy link
Copy Markdown
Member

@weshaggard weshaggard Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: as probably should update this comment but you can do that after this PR is merged.

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will update and revise the script. Thanks.

@weshaggard weshaggard merged commit 72224c4 into dotnet:master Feb 24, 2017
This was referenced Feb 25, 2017
Closed
Merged
This was referenced Feb 25, 2017
Merged
Merged
Merged
@karelz karelz modified the milestone: 2.0.0 Mar 1, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@hqueue @weshaggard
Enable manual CI triggering for arm and armel (dotnet/corefx#16378)
9c651d3 
1. Enable following manual CI triggering for arm and armel.
  Innerloop Ubuntu arm Release Cross Build
  Innerloop Ubuntu arm Debug Cross Build
  Innerloop Ubuntu16.04 arm Release Cross Build
  Innerloop Ubuntu16.04 arm Debug Cross Build
  Innerloop Tizen armel Release Cross Build
  Innerloop Tizen armel Debug Cross Build

  Which replaces following old style commands.
    innerloop linuxarmemulator HardFP Release
    innerloop linuxarmemulator HardFP Debug
    innerloop linuxarmemulator SoftFP Release
    innerloop linuxarmemulator SoftFP Debug

2. Prepare bin/build.tar.gz correctly to run unit tests in coreclr CI for arm and armel.
   Before netci.groovy made old-fashioned build.tar.gz.

3. Add some options to arm32 CI script.

4. Rename scripts/arm32_ci_script.sh to cross/arm32_ci_script.sh

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>

Commit migrated from dotnet/corefx@72224c4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mellinoe mellinoe mellinoe approved these changes

@weshaggard weshaggard weshaggard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mellinoe mellinoe

@hqueue hqueue

Labels

arch-arm32 area-Infrastructure-libraries os-linux Linux OS (any supported distro)

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hqueue @dotnet-bot @mellinoe @weshaggard @karelz @dnfclas