Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fixes System.Runtime.Numerics tests compilation#20813

Merged
mellinoe merged 1 commit intodotnet:masterfrom
marek-safar:build
Jun 8, 2017
Merged

Fixes System.Runtime.Numerics tests compilation#20813
mellinoe merged 1 commit intodotnet:masterfrom
marek-safar:build

Conversation

@marek-safar
Copy link
Copy Markdown
Contributor

Fixes C# compiler error The out parameter 'num3' must be assigned to before control leaves the current method.

It appears that corefx is using pre-RTM buggy version of C# compiler

@danmoseley
Copy link
Copy Markdown
Member

@mellinoe any interest in getting our compiler updated? :)

@danmoseley
Copy link
Copy Markdown
Member

@danmoseley
Copy link
Copy Markdown
Member

@dotnet-bot test Portable Linux x64 Debug Build please (above)

@karelz karelz added this to the 2.1.0 milestone Jun 8, 2017
@mellinoe
Copy link
Copy Markdown
Contributor

mellinoe commented Jun 8, 2017

I'm a bit confused. Where are you seeing compilation errors related to this?

@akoeplinger
Copy link
Copy Markdown
Member

@mellinoe we're consuming these tests (from source) in Mono and compiling with Roslyn 2.3 which throws an error because of the wrong C#. The Roslyn 2.0-rc you're using seems to have a bug and compiles this code regardless.

@mellinoe
Copy link
Copy Markdown
Contributor

mellinoe commented Jun 8, 2017

Understood! Thanks for the clarification. The code change looks good to me.

@mellinoe mellinoe merged commit 440ae75 into dotnet:master Jun 8, 2017
@marek-safar
Copy link
Copy Markdown
Contributor Author

@danmosemsft @karelz I think it'd make sense to release netcore 2.0 version using RTM version of compiler. We hit this issue only but there can be more hidden problems in code we don't use.

@karelz
Copy link
Copy Markdown
Member

karelz commented Jun 9, 2017

I agree, we should upgrade the compiler. I am surprised we would plan to ship with RC compiler when there is RTM compiler. Filed #20869.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants