This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix concurrency in MultipleWaitingClients_ServerServesOneAtATime test#25004
Merged
Conversation
The Unix implementation works by having clients connect to the server socket, and connects are satisifed not when an accept happens but when there's room in the listen backlog. Thus multiple clients might end up having their connects immediately satisfied, and we might try to then read/write the wrong client, and end up deadlocking.
stephentoub
force-pushed
the
fix_np_test
branch
from
a35ef76 to
3c78eb4
Compare
Member
Author
|
@dotnet/dnceng, is there still (or again) an issue with macOS? The leg is showing: I see the same thing on other PRs, e.g. https://ci3.dot.net/job/dotnet_corefx/job/master/job/osx-TGroup_netcoreapp+CGroup_Debug+AGroup_x64+TestOuter_false_prtest/4980/ |
Member
Author
|
Merging to avoid failures happening in other PRs |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…dotnet/corefx#25004) The Unix implementation works by having clients connect to the server socket, and connects are satisifed not when an accept happens but when there's room in the listen backlog. Thus multiple clients might end up having their connects immediately satisfied, and we might try to then read/write the wrong client, and end up deadlocking. Commit migrated from dotnet/corefx@9495387
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unix implementation works by having clients connect to the server socket, and connects are satisifed not when an accept happens but when there's room in the listen backlog. Thus multiple clients might end up having their connects immediately satisfied, and we might try to then read/write the wrong client, and end up deadlocking.
Fixes https://github.com/dotnet/corefx/issues/24994