This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[Fix] [2.1] GH #31082 Existing Transaction SQLBulkCopy#31801
Closed
keeratsingh wants to merge 8 commits intodotnet:release/2.1from
Closed
[Fix] [2.1] GH #31082 Existing Transaction SQLBulkCopy#31801keeratsingh wants to merge 8 commits intodotnet:release/2.1from
keeratsingh wants to merge 8 commits intodotnet:release/2.1from
Conversation
added 7 commits
August 7, 2018 13:40
…qlClient Manual Tests of Helpers.Execute to Helpers.TryExecute
Member
|
@keeratsingh build failures |
Member
|
Not taking at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening PR for 2.1 servicing for Issue #31082
Description
Unexpected existing transactionexception occurs when usingSqlBulkCopyinTransactionScopeCustomer Impact
Customers will not be able to use
SqlBulkCopyinTransactionScope.Regression?
No. SqlBulkCopy code path was missed when
System.Transactionswas ported over from .NET Framework to .NET Core.Risk
Low. The SqlClient driver code change is minimal and has existed in .NET Framework since quite a while. The majority of the changes are test refactoring.