This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Improve BDN benchmarking guide#31963
Merged
adamsitnik merged 2 commits intodotnet:masterfrom Aug 26, 2018
MarcoRossignoli:benchmarking
Merged
Improve BDN benchmarking guide#31963adamsitnik merged 2 commits intodotnet:masterfrom MarcoRossignoli:benchmarking
adamsitnik merged 2 commits intodotnet:masterfrom
MarcoRossignoli:benchmarking
Conversation
adamsitnik
reviewed
Aug 26, 2018
| 4. Define the benchmarks and setup runner | ||
|
|
||
| ```cs | ||
| ... |
Member
There was a problem hiding this comment.
I think that the ... could be removed so only "```" would stay
adamsitnik
reviewed
Aug 26, 2018
| 2. Create a new .NET Core console app using your favorite IDE | ||
| 3. Install BenchmarkDotNet (0.11.1+) | ||
| 4. Define the benchmarks | ||
| 4. Define the benchmarks and setup runner |
Member
There was a problem hiding this comment.
maybe Define the benchmarks and pass the arguments to BenchmarkSwitcher would be better?
adamsitnik
suggested changes
Aug 26, 2018
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
@MarcoRossignoli big thanks for the PR! I found your suggestions very useful!
Could you please remove the extra "```" and change the sentence to "Define the benchmarks and pass the arguments to BenchmarkSwitcher"?
adamsitnik
approved these changes
Aug 26, 2018
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM! Once again big thanks for giving it a try and updating the docs!
Member
Author
|
It's my pleasure thank's for this feature. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* update docs * address PR feedback Commit migrated from dotnet/corefx@4bf7380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve 'Benchmarking .NET Core applications' guide.
I followed 'Recommended workflow' section and added startup sample, to me is more clear and complete.
It's not immediatly clear understand how to start benchmarks that command line will filter.
Feel free to reject if you think it's unuseful.
PS. Works like a charm
/cc @adamsitnik