This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Pin version of S.D.DiagnosticSource on non-netfx platforms#32266
Merged
weshaggard merged 1 commit intodotnet:release/2.1from Sep 13, 2018
Merged
Pin version of S.D.DiagnosticSource on non-netfx platforms#32266weshaggard merged 1 commit intodotnet:release/2.1from
weshaggard merged 1 commit intodotnet:release/2.1from
Conversation
For platforms that aren't .NET Framework we need to pin the version of the reference assembly to avoid ref-def mismatches when running on platforms that have the older version inbox like .NET Core 2.1
safern
approved these changes
Sep 13, 2018
Member
|
test NETFX x86 Release Build |
wtgodbe
approved these changes
Sep 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For platforms that aren't .NET Framework we need to pin the version
of the reference assembly to avoid ref-def mismatches when running on
platforms that have the older version inbox like .NET Core 2.1
cc @ericstj @safern @wtgodbe