Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Increment Microsoft.NETCore.Platforms version#32623

Merged
joshfree merged 1 commit intodotnet:release/2.1from
joshfree:release/2.1
Oct 4, 2018
Merged

Increment Microsoft.NETCore.Platforms version#32623
joshfree merged 1 commit intodotnet:release/2.1from
joshfree:release/2.1

Conversation

@joshfree
Copy link
Member

@joshfree joshfree commented Oct 4, 2018

Bumped Microsoft.NETCore.Platforms version for servicing.
Included missing corert entries from running build -allconfigurations

Ran build.cmd -allconfigurations -- /p:UpdateRuntimeFiles=true
Verified package version change and resultant runtime.json changes

Bumped Microsoft.NETCore.Platforms version for servicing.
Included missing corert entries from running build -allconfigurations

Ran build.cmd -allconfigurations -- /p:UpdateRuntimeFiles=true
Verified package version change and resultant runtime.json changes
@joshfree joshfree added area-Infrastructure-libraries Servicing-consider Issue for next servicing release review labels Oct 4, 2018
@joshfree joshfree added this to the 2.1.x milestone Oct 4, 2018
@joshfree joshfree self-assigned this Oct 4, 2018
@joshfree joshfree requested review from weshaggard and wtgodbe October 4, 2018 19:57
@joshfree
Copy link
Member Author

joshfree commented Oct 4, 2018

Follow on PR to #32292

@joshfree joshfree requested a review from danmoseley October 4, 2018 19:58
"ubuntu-x86"
]
},
"ubuntu.18.10-x86-corert": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these new changes as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are all "-corert' entries that came from building with -allconfigurations

@danmoseley
Copy link
Member

Windows x64 Debug Build failure is unrelated. @joshfree feel free to merge as this is logically part of the changed approved a couple days ago.

@joshfree
Copy link
Member Author

joshfree commented Oct 4, 2018

Windows x64 Debug Build failure is a network test failure; seems to be same/similar error as reported by https://github.com/dotnet/corefx/issues/31772

direct link to test log

System.Net.WebException : A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
---- System.Net.Http.HttpRequestException : A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
-------- System.Net.Sockets.SocketException : A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond

@joshfree joshfree added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 4, 2018
@joshfree
Copy link
Member Author

joshfree commented Oct 4, 2018

Marking as servicing-approved per shiproom rep

@joshfree joshfree merged commit 933b031 into dotnet:release/2.1 Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments