This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add tests for unbox expressions and remove incorrect assertion#3874
Merged
Conversation
JonHanna
force-pushed
the
unbox_expression_tests
branch
2 times, most recently
from
bd02cee to
642fdad
Compare
Member
|
LGTM cc: @VSadov |
JonHanna
force-pushed
the
unbox_expression_tests
branch
from
642fdad to
ea7c477
Compare
JonHanna
force-pushed
the
unbox_expression_tests
branch
from
ea7c477 to
3ae7592
Compare
Contributor
Author
|
The fix to #3873 was included in #4025, and since that's been merged in, this no longer covers that. |
Member
|
test this please |
VSadov
added a commit
that referenced
this pull request
Nov 13, 2015
Add tests for unbox expressions and remove incorrect assertion
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…tests Add tests for unbox expressions and remove incorrect assertion Commit migrated from dotnet/corefx@fe9351e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3873 as the incorrect assertions would cause these tests to fail
incorrectly, and the assertions should only affect such tests.