This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Stop emitting a BOM into stdin when using System.Diagnostics.Process#4032
Merged
Conversation
When using standard input redirection on Unix with System.Diagnostics.Process, the code would emit a BOM. This screws up many unix tools which don't understand the BOM.
Member
|
LGTM |
Author
|
@stephentoub can you review? @caslan FYI |
Author
|
You reviewed it faster than I can ask :) |
Member
|
😄 |
Member
|
@dotnet-bot test this please |
stephentoub
added a commit
that referenced
this pull request
Oct 21, 2015
Stop emitting a BOM into stdin when using System.Diagnostics.Process
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Stop emitting a BOM into stdin when using System.Diagnostics.Process Commit migrated from dotnet/corefx@5bc2e99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using standard input redirection on Unix with System.Diagnostics.Process, the code would emit a BOM. This screws up many unix tools which don't understand the BOM.