Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Added tests to cover all reachable branches when backed by JsonNode#41252

Merged
safern merged 1 commit intodotnet:masterfrom
AntonLandor:master
Sep 27, 2019
Merged

Added tests to cover all reachable branches when backed by JsonNode#41252
safern merged 1 commit intodotnet:masterfrom
AntonLandor:master

Conversation

@AntonLandor
Copy link
Copy Markdown
Contributor

Solves #41130. Reachable branches covered.

@ahsonkhan ahsonkhan added this to the 5.0 milestone Sep 25, 2019
@ahsonkhan ahsonkhan added the test enhancement Improvements of test source code label Sep 25, 2019
@ahsonkhan
Copy link
Copy Markdown

Were you able to verify that JsonElement/GetDouble/GetSingle are covered by a netfx specific test?

Copy link
Copy Markdown

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@safern
Copy link
Copy Markdown
Member

safern commented Sep 27, 2019

Merging per approval, green CI, and no activity in 3 days.

@safern safern merged commit 867c317 into dotnet:master Sep 27, 2019
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.Json test enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants