Add shim for libcurl version info.#4186
Conversation
There was a problem hiding this comment.
Nit: I wonder if this should be "curl_version_info" rather than "GetCurlVersionInfo", since curl_version_info is part of the libcurl public interface whereas GetCurlVersionInfo is an internal implementation detail of our solution.
There was a problem hiding this comment.
Changed it to curl_version_info.
|
One minor wording question, otherwise looks great. |
There was a problem hiding this comment.
It looks like we call this from one place and we pass in each variable...why not make these asserts that they are non-nullptr and then just set them?
There was a problem hiding this comment.
I was always taught to check pointers before dereferencing them in C++ code.
|
One minor question but otherwise LGTM |
There was a problem hiding this comment.
Other projects depend on this file and is the cause of build failure.
Adding a native shim for curl_version_info and removing the managed constants that are no longer needed.
Add shim for libcurl version info.
Add shim for libcurl version info. Commit migrated from dotnet/corefx@8924a5c
8 participants
Adding a native shim for curl_version_info and removing the managed constants that are no longer needed.
@kapilash @nguerrera @sokket @stephentoub