This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Support Correct exception for windows authentication failure on Xplat#4197
Merged
Conversation
Contributor
Author
|
cc @stephentoub |
Member
There was a problem hiding this comment.
Is SR.GetString rather than SR.Format the way the rest of the library does it?
Contributor
Author
There was a problem hiding this comment.
SR.GetString has been added to SqlClient and is used everywhere in the library. So for consistency I went ahead with it.
Member
|
LGTM |
Member
|
@dotnet-bot test this please (https://github.com/dotnet/corefx/issues/4204) |
stephentoub
added a commit
that referenced
this pull request
Oct 28, 2015
Support Correct exception for windows authentication failure on Xplat
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Support Correct exception for windows authentication failure on Xplat Commit migrated from dotnet/corefx@388b3e5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding PlatformNotSupported exception as a fix for https://github.com/dotnet/corefx/issues/2461