Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add some missing using statements.#4218

Merged
pgavlin merged 1 commit into
dotnet:masterfrom
pgavlin:GH4143
Oct 29, 2015
Merged

Add some missing using statements.#4218
pgavlin merged 1 commit into
dotnet:masterfrom
pgavlin:GH4143

Conversation

@pgavlin
Copy link
Copy Markdown
Contributor

@pgavlin pgavlin commented Oct 28, 2015

The lack of these statements was breaking the TFS build.

Fixes #4143.

@pgavlin
Copy link
Copy Markdown
Contributor Author

pgavlin commented Oct 28, 2015

@davidsh @mconnew PTAL. I'm validating the TFS build now.

@pgavlin
Copy link
Copy Markdown
Contributor Author

pgavlin commented Oct 28, 2015

(with some help from @ellismg :))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to delete this var inner = ex; line, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch--I thought I had. Thanks.

The lack of these statements was breaking the TFS build.

Fixes #4143.
@stephentoub
Copy link
Copy Markdown
Member

I don't think this will build as part of the CI, so if it builds for you successfully locally, LGTM.

@davidsh
Copy link
Copy Markdown
Contributor

davidsh commented Oct 28, 2015

LGTM

@ellismg
Copy link
Copy Markdown
Contributor

ellismg commented Oct 29, 2015

LGTM. It built fine internally, modulo some existing breaks in other projects we already know about.

pgavlin added a commit that referenced this pull request Oct 29, 2015
Add some missing using statements.
@pgavlin pgavlin merged commit 8ffae31 into dotnet:master Oct 29, 2015
@pgavlin pgavlin deleted the GH4143 branch October 29, 2015 00:55
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Add some missing using statements.

Commit migrated from dotnet/corefx@8ffae31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants