This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Ignore EPIPE errors on Unix when writing to Console#4221
Merged
Conversation
If you pipe from a managed app to another app that ends (or doesn't exist to begin with), attempting to write to it via Console will throw an exception due to the pipe getting broken. This commit just changes Console's Write to ignore EPIPE (broken pipe) errors. For now I still have it throw an other failures, but we could choose to add additional ignored errno values to the list, or simply not throw for anything.
Contributor
|
Seems reasonable. |
Contributor
|
LGTM |
Contributor
|
LGTM, thanks for the quick fix |
Member
Author
|
Thanks, guys. |
stephentoub
added a commit
that referenced
this pull request
Oct 29, 2015
Ignore EPIPE errors on Unix when writing to Console
stephentoub
added a commit
to stephentoub/corefx
that referenced
this pull request
Oct 29, 2015
This is another attempt at dotnet#4212, which was then immediately reverted in dotnet#4220 because it broke some internal build stuff due to the APIs being used. Changes on Windows: - When an Assert fires and the debugger isn't attached, instead of Environment.FailFast'ing, we throw an exception. - When an Assert fires, we were previously calling Debug.WriteLine twice; now we only call it once. Changes on Unix: - Made the Assert functionality match that of Windows in terms of the APIs being called. - Changed WriteCore to check Debugger.IsLogging and, if it's true, do a Debugger.Log, just as we do on Windows. Right now these are nops, but when that changes this will become useful. The fallback when IsLogging is false remains the same: write to syslog. - Fixed the WriteToStderr function to ignore errors from Write, as we don't want this function throwing exceptions due to failed attempts to output to stderr, such as if it was piped to another program that ended before this one (as with dotnet#4221).
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…okenpipe Ignore EPIPE errors on Unix when writing to Console Commit migrated from dotnet/corefx@c837eb9
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This is another attempt at dotnet/corefx#4212, which was then immediately reverted in dotnet/corefx#4220 because it broke some internal build stuff due to the APIs being used. Changes on Windows: - When an Assert fires and the debugger isn't attached, instead of Environment.FailFast'ing, we throw an exception. - When an Assert fires, we were previously calling Debug.WriteLine twice; now we only call it once. Changes on Unix: - Made the Assert functionality match that of Windows in terms of the APIs being called. - Changed WriteCore to check Debugger.IsLogging and, if it's true, do a Debugger.Log, just as we do on Windows. Right now these are nops, but when that changes this will become useful. The fallback when IsLogging is false remains the same: write to syslog. - Fixed the WriteToStderr function to ignore errors from Write, as we don't want this function throwing exceptions due to failed attempts to output to stderr, such as if it was piped to another program that ended before this one (as with dotnet/corefx#4221). Commit migrated from dotnet/corefx@68e46ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you pipe from a managed app to another app that ends (or doesn't exist to begin with), attempting to write to it via Console will throw an exception due to the pipe getting broken.
This commit just changes Console's Write to ignore EPIPE (broken pipe) errors. For now I still have it throw an other failures, but we could choose to add additional ignored errno values to the list, or simply not throw for anything.
Fixes #4219
cc: @mellinoe, @ellismg