Skip to content

Fix overload resolution for non-returning async lambdas matching task-returning delegates#1022

Merged
BillWagner merged 1 commit intodotnet:draft-v8from
jskeet:fix-overload-resolution
Nov 30, 2023
Merged

Fix overload resolution for non-returning async lambdas matching task-returning delegates#1022
BillWagner merged 1 commit intodotnet:draft-v8from
jskeet:fix-overload-resolution

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Nov 30, 2023

Fixes #625 (which contains more details)

We can merge this when you're happy, Bill.

@jskeet jskeet requested a review from BillWagner November 30, 2023 07:34
Copy link
Copy Markdown
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I still wonder what S was (or if it was a typo).

@BillWagner BillWagner merged commit 0e69b5e into dotnet:draft-v8 Nov 30, 2023
@jskeet jskeet deleted the fix-overload-resolution branch November 30, 2023 14:03
@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Nov 30, 2023

This LGTM. I still wonder what S was (or if it was a typo).

Left over from the clause above, I suspect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check preference for Func<Task> over Action

2 participants