Tweak the MaybeNull attribute test examples #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Nov 7, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @RexJaeschke
I'll 
now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Addresses the 2nd test issue in PR #1451.]
@BillWagner I couldn't come up with a failing-code replacement for MaybeNull1Attribute, but other sibling attributes don't show an error case that is resolved by the presence of an attribute, so I mimicked them.
Note that I wrote "the compiler might generate a warning if the method could return
null." In the test case, the return value ofdefaultis seen by the compiler, so it knows a null is being returned. I couldn't come up with a replacement for the return statement that didn't explicitly return null. So I couldn't say for certain that it would generate a warning.