Make OpenAITelemetryPlugin record report metrics only if 'recording' is on #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-OpenAITelemetryPlugin
waldekmastykarz
requested changes
Nov 22, 2025
Collaborator
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Rather than introducing a whole new way of handling recording, let's use the existing approach that we have, for example here:
. It will mean some more changes in the plugin but it'll be consistent with other plugins and fewer changes to the core functionality.
…n-OpenAITelemetryPlugin
…n-OpenAITelemetryPlugin
waldekmastykarz
approved these changes
Nov 28, 2025
Collaborator
waldekmastykarz
left a comment
waldekmastykarz
left a comment
There was a problem hiding this comment.
Very nice! I removed one unused object but other than that nothing to add 👏
bartizan
deleted the
1440_record-model-usage-after-recording-is-on-OpenAITelemetryPlugin
branch
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1440