Changes config get to download configs to user data folder instead of installation folder. Closes #1564#1614
Open
waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
Open
Changes config get to download configs to user data folder instead of installation folder. Closes #1564#1614waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
waldekmastykarz wants to merge 2 commits intodotnet:mainfrom
Conversation
… installation folder. Closes dotnet#1564
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the config get workflow so that downloaded gallery configs are stored in the per-user Dev Proxy data directory (instead of the installation directory), ensuring they survive upgrades and enabling use of a new ~dataFolder path token.
Changes:
- Download
config getoutputs to~dataFolder/configs/<config-id>/...rather than<install>/config/.... - Introduce
ProxyUtils.DataFolderand add support for the~dataFoldertoken in path resolution. - Update CLI help/output to reference
~dataFolderwhere appropriate.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DevProxy/Commands/DevProxyCommand.cs | Updates --config-file help text to mention ~dataFolder token support. |
| DevProxy/Commands/ConfigCommand.cs | Moves config get download target from installation config/ to user data configs/ and updates printed example commands. |
| DevProxy.Abstractions/Utils/ProxyUtils.cs | Adds DataFolder and expands ReplacePathTokens to handle ~dataFolder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes config get to download configs to user data folder instead of installation folder. Closes #1564