Skip to content

Fix crash when multiple plugins register the same command #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldekmastykarz merged 2 commits into from
Jun 4, 2026
+12 −1
Merged

Fix crash when multiple plugins register the same command #1691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5572bdc
Fix crash when multiple plugins register the same command
waldekmastykarz Jun 4, 2026
c333773
Merge branch 'main' into waldekmastykarz/fix-duplicate-plugin-commands
waldekmastykarz Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion DevProxy/Commands/DevProxyCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,18 @@ private void ConfigureCommand()
ActivatorUtilities.CreateInstance<StopCommand>(_serviceProvider),
ActivatorUtilities.CreateInstance<LogsCommand>(_serviceProvider)
};
commands.AddRange(_plugins.SelectMany(p => p.GetCommands()));
var pluginCommands = _plugins.SelectMany(p => p.GetCommands());
foreach (var group in pluginCommands.GroupBy(c => c.Name))
{
var command = group.First();
commands.Add(command);
if (group.Count() > 1)
{
_logger.LogWarning(
"Multiple plugins register the '{CommandName}' command. Only the first registration will be used",
command.Name);
}
}
this.AddCommands(commands.OrderByName());

HelpExamples.Add(this, [
Expand Down
Loading