Handle exception in System.Console.SetCursorPosition in some environments#3678
Merged
noahfalk merged 1 commit intodotnet:mainfrom Mar 8, 2023
Merged
Handle exception in System.Console.SetCursorPosition in some environments#3678noahfalk merged 1 commit intodotnet:mainfrom
noahfalk merged 1 commit intodotnet:mainfrom
Conversation
…ents System.ArgumentOutOfRangeException: The value must be greater than or equal to zero and less than the console's buffer size in that dimension. (Parameter 'top') Actual value was -1. at System.Console.SetCursorPosition(Int32 left, Int32 top) at Microsoft.Internal.Common.Utils.LineRewriter.SystemConsoleLineRewriter() at Microsoft.Internal.Common.Utils.LineRewriter.RewriteConsoleLine() at Microsoft.Diagnostics.Tools.Trace.CollectCommandHandler.<>c__DisplayClass6_2.b__4() at Microsoft.Diagnostics.Tools.Trace.CollectCommandHandler.Collect(CancellationToken ct, IConsole console, Int32 processId, FileInfo output, UInt32 buffersize, String providers, String profile, TraceFileFormat format, TimeSpan duration, String clrevents, String clreventlevel, String name, String diagnosticPort, Boolean showchildio, Boolean resumeRuntime
Member
|
@dotnet/dotnet-diag in case anyone else wants to take a look @HJLeee - Thanks for the updated version👍 Are you ready to have this merged? |
Contributor
Author
Yes. Please merge this. :) |
gbalykov
approved these changes
Feb 27, 2023
Contributor
Author
|
@noahfalk Please let me know anything necessary for merge. |
Member
|
My apologies I just missed your message. Very sorry about that! |
Contributor
Author
|
Thank you. Have a good day. 👍 |
HJLeee
added a commit
to HJLeee/diagnostics
that referenced
this pull request
Jun 14, 2023
…ents for dotnet-* tools (dotnet#3678)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply feedback.
#3635 (comment)
Now it looks like the below when
System.Console.SetCursorPosition(Int32 left, Int32 top)throws exception.cc/ @gbalykov @noahfalk