Fix a timeout exception causing unhandled exception crash #492
Conversation
|
@mikem8361 Is release/3.0 branch still open? I'd like to merge this into 3.0 official release possible |
josalem
left a comment
josalem
left a comment
There was a problem hiding this comment.
Is there a way we can differentiate between "The pipe never existed" and "the pipe has stopped existing"? Right now I think this will catch for both scenarios, which means we won't have a -1 exit code for pointing counters at an incompatible process. For now, I think this is fine though.
…compatible runtimes from early exits
|
@josalem thanks for catching that. That's a really good point. I can move the exception handling to StopMonitor to distinguish the two. |
|
You can go ahead and merged into release/3.0.
|
|
@mikem8361 Do you have a preference between merging this to master first, then cherry-picking it, or just creating a separate PR to release/3.0? |
|
It doesn’t really matter as long as it makes it into master too. The infrastructure changes I’m working are going into release/3.0 then I’m going to cherry pick them into master.
|
|
OK as soon as the CI is green I'll merge this to master and cherry-pick it to release/3.0. Thanks Mike! |
* Fix a timeout exception causing unhandled exception crash * Fix the same issue on Unix too * Move the exception handling to StopMonitor to distinguish actually incompatible runtimes from early exits * fix build error
3 participants
@josalem just reported an issue where if the app exits before dotnet-counters, we get a timeout on StopTracing command and it crashes dotnet-counters with an unhandled exception. This fixes that bad behavior.