Permit the Module address to be optional for sig parsing. #5480
+225
−165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It isn't uncommon to want to examine a .NET signature, but not care about resolving tokens. This change makes providing the associated module optional and emits the token value instead. This change also makes this behavior the failure case in the event the associated MetaDataImport returns a failure code.
Member
Author
|
/cc @mikem8361 |
hoyosjs
previously approved these changes
May 12, 2025
Member
Author
|
I have one more update to this API. Generic signatures don't appear to be respected. I'll fix that quickly. |
Remove deprecated naming
hoyosjs
approved these changes
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't uncommon to want to examine a .NET signature, but not care about resolving tokens. This change makes providing the associated module optional and emits the token value instead. This change also makes this behavior the failure case in the event the associated
IMetaDataImportreturns a failure code.View without whitespace diffs - https://github.com/dotnet/diagnostics/pull/5480/files?diff=split&w=1